Generate RPM package #2200
Merged
Generate RPM package #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An RPM package is now generated as part of the Linux packaging script. The packaging script can be run on any Debian or Redhat based system and will generate both a deb and rpm package. Resolves bisq-network#401
|
This is pending on #2190 to be approved and merged. |
ripcurlx
suggested changes
Jan 7, 2019
There was a problem hiding this comment.
@devinbileck Now as the linux build scripts are merged, could you please resolve the conflict and I'll merge the PR.
…m-package # Conflicts: # desktop/package/linux/package.sh # desktop/package/linux/release.sh
…m-package # Conflicts: # desktop/package/linux/package.sh # desktop/package/linux/rpm.sh
|
@ripcurlx please take a look now. |
|
@devinbileck Can you please resolve the conflicts and I'm happy to review and merge. 😄 |
…m-package # Conflicts: # desktop/package/linux/package.sh # desktop/package/linux/rpm.sh
# Conflicts: # desktop/package/linux/package.sh
ripcurlx
approved these changes
Jan 14, 2019
|
@devinbileck I've merged the last part which was necessary because of another approved PR. |
devinbileck
added a commit
to devinbileck/bisq
that referenced
this pull request
Feb 17, 2019
Currently, the download update task will download the deb package for any Linux distribution. Not only is this incorrect, but now that we are able to provide an rpm package (see bisq-network#2200), the download update task needs to be able to differentiate Linux distributions and provide the appropriate package. The download update task will now differentiate between Debian and RedHat based distributions (the two distributions for which we have an install package) and download the appropriate package. In addition, the isSupportedOS method was changed to exclusively check for Debian and RedHat based distributions, as opposed to just Linux in general. This means that any other distribution will encounter the following error, which seems appropriate: > Unable to determine the correct installer. Please download and verify manually at https://bisq.network/downloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An RPM package is now generated as part of the Linux packaging script.
The packaging script can be run on any Debian or Redhat based
system and will generate both a deb and rpm package.
Resolves #401